Re: [PATCH v2 06/14] config.c: pass kvi in configsets

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 1, 2023, 22:21 UTC
Message-ID: <20230601222102.420798-1-jonathantanmy@google.com>
In-Reply-To: <f57c1007cad106a6387c77ac4d06208d39bfb9f8.1685472133.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: Glen Choo <chooglen@google.com>
> 
> Trivially pass "struct key_value_info" to config callbacks in
> configset_iter(). Then, in config callbacks that are only used with
> configsets, use the "kvi" arg to replace calls to current_config_*(),

OK, so the end result of this patch is, indeed, that configset_iter() passes kvi, and this is proven by some callbacks being changed to use the kvi provided, and still functioning. I did not verify that the callbacks in this patch were the *only* callbacks that are only used with configsets, but I don't think that is important for the purpose of reviewing this patch - as long as current_config_* has all been removed at the end of this patchset, then things are fine.

> and delete current_config_line() because it has no remaining callers.

Ah, great that we can remove one of the global-reliant functions as a
result of this.