git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/1] Unit tests for khash.h

From
EWEric Wong <e@80x24.org>
Date
May 31, 2023, 23:35 UTC
Message-ID
<20230531233526.M226883@dcvr>
In-Reply-To
<20230531155142.3359886-1-siddhartth@google.com>
Siddharth Singh <siddhartth@google.com> wrote:
> This RFC patch adds unit tests for khash.h.

I agree with what Taylor said about being skeptical of these tests being productive.

I'm curious about switching parts of git to use AC's newer `khashl'. khashl is smaller than the original khash but slower for deletes. Since git hardly deletes and khash memory use is high (especially on packing); it should be a benefit all around.

Also, see Documentation/CodingGuidelines for coding style.
Previous: Phillip WoodNext: Phillip Wood
Message 6 of 12 in “Unit tests for khash.h”
  1. 0/1 Unit tests for khash.hSiddharth Singh, May 31, 2023
  2. 1/1 khash_test.c: add unit testsSiddharth Singh, May 31, 2023
  3. Taylor BlauMay 31, 2023
  4. Junio C HamanoJun 1, 2023
  5. Phillip WoodJun 1, 2023
  6. Eric WongMay 31, 2023
  7. Phillip WoodJun 1, 2023
  8. khash_test.c : add unit testsSiddharth Singh, Jun 27, 2023
  9. Glen ChooJun 30, 2023
  10. Siddharth SinghJul 7, 2023
  11. Glen ChooJul 7, 2023
  12. Glen ChooJun 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.