From: Eric Wong <e@80x24.org>
Date: Wed, 31 May 2023 23:35:26 GMT
Subject: Re: [RFC PATCH 0/1] Unit tests for khash.h
Message-ID: <20230531233526.M226883@dcvr>
In-Reply-To: <20230531155142.3359886-1-siddhartth@google.com>

Siddharth Singh <siddhartth@google.com> wrote:
> This RFC patch adds unit tests for khash.h.

I agree with what Taylor said about being skeptical of these
tests being productive.

I'm curious about switching parts of git to use AC's newer `khashl'.
khashl is smaller than the original khash but slower for deletes.
Since git hardly deletes and khash memory use is high (especially on
packing); it should be a benefit all around.

Also, see Documentation/CodingGuidelines for coding style.