Re: [PATCH v3 0/1] Fix empty SHA-256 clones with v0 and v1
- From
Jeff King <peff@peff.net>
- Date
- May 18, 2023, 18:28 UTC
- Message-ID
- <20230518182838.GB557383@coredump.intra.peff.net>
- In-Reply-To
- <20230517192443.1149190-1-sandals@crustytoothpaste.net>
On Wed, May 17, 2023 at 07:24:42PM +0000, brian m. carlson wrote:
> Changes since v2: > * Move advertisement of fake capabilities ref to a separate function to > avoid an extra strcmp.
Thanks, the code change looks good to me.
I'm still a little puzzled why we need http tests both in t5551 and t5700. Not too big a deal to have redundant tests, obviously, but I wonder if I am missing something.
-Peff