Re: [PATCH] doc: asciidoc: remove custom header macro

From: Jeff King <peff@peff.net>
Date: Apr 6, 2023, 07:19 UTC
Message-ID: <20230406071958.GB2143526@coredump.intra.peff.net>
In-Reply-To: <xmqq8rf5r66s.fsf@gitster.g>

On Wed, Apr 05, 2023 at 09:22:03PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> Sounds like the proposed log message can use a bit more polishing to
> help future readers of "git log", then.  But I think it is not
> required to be explicit about us leaving the asciidoctor side
> untouched to keep it working (in other words, we do not talk about
> things that we are not doing in our log message, unless it is so
> unnatural not to do them at the same time to warrant such an
> explanation).

Yes, I think the "is it unnatural" is a debatable point here. I'm OK with the commit message as-is.

> Will queue with your Reviewed-by: in the morning.

Sounds good, thanks.

-Peff