Re: [PATCH] doc: asciidoc: remove custom header macro

From: Jeff King <peff@peff.net>
Date: Apr 6, 2023, 03:57 UTC
Message-ID: <20230406035729.GA2092667@coredump.intra.peff.net>
In-Reply-To: <20230323221523.52472-1-felipe.contreras@gmail.com>

On Thu, Mar 23, 2023 at 04:15:23PM -0600, Felipe Contreras wrote:

Show 13 quoted lines

> In 2007 we added a custom header macro to provide version information
> 7ef195ba3e (Documentation: Add version information to man pages,
> 2007-03-25),
> 
> However, in 2008 asciidoc added the attributes to do this properly [1].
> 
> This was not implemented in Git until 2019: 226daba280 (Doc/Makefile:
> give mansource/-version/-manual attributes, 2019-09-16).
> 
> But in 2023 we are doing it properly, so there's no need for the custom
> macro.
> 
> [1] https://github.com/asciidoc-py/asciidoc-py/commit/ad78a3c

This should be OK to do, as it is just touching the python asciidoc side. When we discussed those attributes in 2019:

  https://lore.kernel.org/git/20190320183229.GK31362@pobox.com/

asciidoctor support was new and incomplete. It needed v1.5.7 (from 2018), and even today still does not seem to handle manversion. But since this patch leaves in place the equivalent hack in asciidoctor-extensions.rb, it will continue working.

  Aside: If we think asciidoctor 1.5.7 is recent enough to rely on, then
  we might want to simplify our hack to just output manversion. Right
  now we generate duplicate "source" and "manual" lines, though docbook
  seems to do OK with it.

-Peff