Re: [PATCH v2 0/5] some chainlint fixes and performance improvements

From: Jeff King <peff@peff.net>
Date: Mar 30, 2023, 22:09 UTC
Message-ID: <20230330220915.GA1914330@coredump.intra.peff.net>
In-Reply-To: <xmqqjzyyhtel.fsf@gitster.g>

On Thu, Mar 30, 2023 at 01:32:34PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> >   [5/5]: tests: skip test_eval_ in internal chain-lint
> 
> The new step [3/5] makes it easier to justify [4/5], indeed.  Two
> primary changes at the beginning are good as before.  The last one
> does not make anything particularly easier to read, replacing one
> cryptic eval stuff with another, but it does not make it any worse,
> and the most importantly, it is clear to see that it does not change
> the behaviour.

Yeah, the eval garbage is horrid no matter where it is. The improvement is that we no longer have to manually save-and-restore the "trace" variable.

> Will queue.  Thanks.  Let's merge it down to 'next'.

Great, thanks. :)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.