git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup

From
Shuqi Liang <cheskaqiqi@gmail.com>
Date
Feb 15, 2023, 17:55 UTC
Message-ID
<20230215175510.3631-1-cheskaqiqi@gmail.com>
In-Reply-To
<20230215104246.8919-2-mcsm224@gmail.com>
Hello  Idriss,
I have some suggestions:

Seen like you didn't describe the existing problem and how you fix it in the commit message. You can start with a description of the existing problem in the present tense in your commit message. Also, you should use the imperative mood to describe the change you make.

Maybe you can write something like the below in your commit message after you use git commit -s. ---------------------------------------------------------------------------------------- trace.c, git.c: removed unnecessary parameter to trace_repo_setup

your description of the existing problem.............
Fix them.
Signed-off-by: ...
-------------------------------------------------------------------------------------------

Regards, Shuqi

Previous: Idriss FekirNext: Junio C Hamano
Message 3 of 9 in “trace.c, git.c: removed unnecessary parameter to trace_repo_setup”
  1. 0/1 [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setupIdriss Fekir, Feb 15, 2023
  2. 1/1 remove parameter (prefix) from trace_repo_setupIdriss Fekir, Feb 15, 2023
  3. Shuqi LiangFeb 15, 2023
  4. Junio C HamanoFeb 15, 2023
  5. 1/1 trace.c, git.c: remove unnecessary parameter to trace_repo_setupIdriss Fekir, Feb 15, 2023
  6. Christian CouderFeb 18, 2023
  7. 1/1 trace.c, git.c: remove unnecessary parameter to trace_repo_setup()Idriss Fekir, Feb 19, 2023
  8. Junio C HamanoFeb 21, 2023
  9. Idriss FekirFeb 22, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.