git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] remove parameter (prefix) from trace_repo_setup

From
Idriss Fekir <mcsm224@gmail.com>
Date
Feb 15, 2023, 10:42 UTC
Message-ID
<20230215104246.8919-2-mcsm224@gmail.com>
In-Reply-To
<20230215104246.8919-1-mcsm224@gmail.com>
From: idriss fekir <mcsm224@gmail.com>
Signed-off-by: Idriss Fekir <mcsm224@gmail.com>
---
 git.c   | 2 +-
 trace.c | 6 +++---
 trace.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/git.c b/git.c
index 96b0a2837d..6171fd6769 100644
--- a/git.c
+++ b/git.c
@@ -430,7 +430,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
 		use_pager = 1;
 	if (run_setup && startup_info->have_repository)
 		/* get_git_dir() may set up repo, avoid that */
-		trace_repo_setup(prefix);
+		trace_repo_setup();
 	commit_pager_choice();
 
 	if (!help && p->option & NEED_WORK_TREE)
diff --git a/trace.c b/trace.c
index 794a087c21..316070a43e 100644
--- a/trace.c
+++ b/trace.c
@@ -292,9 +292,9 @@ static const char *quote_crnl(const char *path)
 }
 
 /* FIXME: move prefix to startup_info struct and get rid of this arg */
-void trace_repo_setup(const char *prefix)
+void trace_repo_setup()
 {
-	const char *git_work_tree;
+	const char *git_work_tree, *prefix = startup_info->prefix;
 	char *cwd;
 
 	if (!trace_want(&trace_setup_key))
@@ -305,7 +305,7 @@ void trace_repo_setup(const char *prefix)
 	if (!(git_work_tree = get_git_work_tree()))
 		git_work_tree = "(null)";
 
-	if (!prefix)
+	if (!startup_info->prefix)
 		prefix = "(null)";
 
 	trace_printf_key(&trace_setup_key, "setup: git_dir: %s\n", quote_crnl(get_git_dir()));
diff --git a/trace.h b/trace.h
index 4e771f86ac..ca943037c6 100644
--- a/trace.h
+++ b/trace.h
@@ -93,7 +93,7 @@ extern struct trace_key trace_default_key;
 extern struct trace_key trace_perf_key;
 extern struct trace_key trace_setup_key;
 
-void trace_repo_setup(const char *prefix);
+void trace_repo_setup();
 
 /**
  * Checks whether the trace key is enabled. Used to prevent expensive
-- 
2.39.1
Previous: Idriss FekirNext: Shuqi Liang
Message 2 of 9 in “trace.c, git.c: removed unnecessary parameter to trace_repo_setup”
  1. 0/1 [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setupIdriss Fekir, Feb 15, 2023
  2. 1/1 remove parameter (prefix) from trace_repo_setupIdriss Fekir, Feb 15, 2023
  3. Shuqi LiangFeb 15, 2023
  4. Junio C HamanoFeb 15, 2023
  5. 1/1 trace.c, git.c: remove unnecessary parameter to trace_repo_setupIdriss Fekir, Feb 15, 2023
  6. Christian CouderFeb 18, 2023
  7. 1/1 trace.c, git.c: remove unnecessary parameter to trace_repo_setup()Idriss Fekir, Feb 19, 2023
  8. Junio C HamanoFeb 21, 2023
  9. Idriss FekirFeb 22, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.