git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 2/4] t1301: use test_when_finished for cleanup

From
Jiang Xin <worldhello.net@gmail.com>
Date
Nov 27, 2022, 14:51 UTC
Message-ID
<20221127145130.16155-2-worldhello.net@gmail.com>
In-Reply-To
<20221127145130.16155-1-worldhello.net@gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
---
 t/t1301-shared-repo.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index 7578e75d77..1225abbb6d 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -25,6 +25,7 @@ test_expect_success 'shared = 0400 (faulty permission u-w)' '
 for u in 002 022
 do
 	test_expect_success POSIXPERM "shared=1 does not clear bits preset by umask $u" '
+		test_when_finished "rm -rf sub" &&
 		mkdir sub && (
 			cd sub &&
 			umask $u &&
@@ -42,7 +43,6 @@ do
 			;;
 		esac
 	'
-	rm -rf sub
 done
 
 test_expect_success 'shared=all' '
@@ -132,6 +132,7 @@ test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
 '
 
 test_expect_success POSIXPERM 'forced modes' '
+	test_when_finished "rm -rf new" &&
 	mkdir -p templates/hooks &&
 	echo update-server-info >templates/hooks/post-update &&
 	chmod +x templates/hooks/post-update &&
@@ -174,6 +175,7 @@ test_expect_success POSIXPERM 'forced modes' '
 '
 
 test_expect_success POSIXPERM 'remote init does not use config from cwd' '
+	test_when_finished "rm -rf child.git" &&
 	git config core.sharedrepository 0666 &&
 	umask 0022 &&
 	git init --bare child.git &&
@@ -193,7 +195,7 @@ test_expect_success POSIXPERM 're-init respects core.sharedrepository (local)' '
 '
 
 test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)' '
-	rm -rf child.git &&
+	test_when_finished "rm -rf child.git" &&
 	umask 0022 &&
 	git init --bare --shared=0666 child.git &&
 	test_path_is_missing child.git/foo &&
@@ -204,7 +206,7 @@ test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)'
 '
 
 test_expect_success POSIXPERM 'template can set core.sharedrepository' '
-	rm -rf child.git &&
+	test_when_finished "rm -rf child.git" &&
 	umask 0022 &&
 	git config core.sharedrepository 0666 &&
 	cp .git/config templates/config &&
-- 
2.39.0.rc0
Previous: Jiang XinNext: Junio C Hamano
Message 2 of 24 in “t1301: fix wrong template dir for git-init”
  1. 1/4 t1301: fix wrong template dir for git-initJiang Xin, Nov 27, 2022
  2. 2/4 t1301: use test_when_finished for cleanupJiang Xin, Nov 27, 2022
  3. Junio C HamanoNov 28, 2022
  4. 3/4 t1301: wrap the statements in the for loopJiang Xin, Nov 27, 2022
  5. Junio C HamanoNov 28, 2022
  6. Jiang XinNov 28, 2022
  7. Jiang XinNov 28, 2022
  8. 4/4 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 27, 2022
  9. Junio C HamanoNov 28, 2022
  10. Jiang XinNov 28, 2022
  11. 1/3 t1301: fix wrong template dir for git-initJiang Xin, Nov 28, 2022
  12. Ævar Arnfjörð BjarmasonNov 28, 2022
  13. Jiang XinNov 28, 2022
  14. Ævar Arnfjörð BjarmasonNov 28, 2022
  15. 2/3 t1301: use test_when_finished for cleanupJiang Xin, Nov 28, 2022
  16. 3/3 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 28, 2022
  17. Ævar Arnfjörð BjarmasonNov 28, 2022
  18. Jiang XinNov 28, 2022
  19. Junio C HamanoNov 29, 2022
  20. 0/3 t1301: various updatesJiang Xin, Nov 28, 2022
  21. 0/3 t1301: various updatesJiang Xin, Nov 29, 2022
  22. 1/3 t1301: fix wrong template dir for git-initJiang Xin, Nov 29, 2022
  23. 2/3 t1301: use test_when_finished for cleanupJiang Xin, Nov 29, 2022
  24. 3/3 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 29, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.