git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 1/4] t1301: fix wrong template dir for git-init

From
Jiang Xin <worldhello.net@gmail.com>
Date
Nov 27, 2022, 14:51 UTC
Message-ID
<20221127145130.16155-1-worldhello.net@gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc.com>

The template dir parepared in test case "forced modes" is not used as expected because a wrong template dir is provided to "git init". This is because the $CWD for "git-init" command is a sibling directory alongside the template directory. Change it to the right template directory and add a protection test using "test_path_is_file".

The wrong template directory was introduced by mistake in commit e1df7fe43f (init: make --template path relative to $CWD, 2019-05-10).

Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
---
 t/t1301-shared-repo.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index 93a2f91f8a..7578e75d77 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -140,7 +140,8 @@ test_expect_success POSIXPERM 'forced modes' '
 	(
 		cd new &&
 		umask 002 &&
-		git init --shared=0660 --template=templates &&
+		git init --shared=0660 --template=../templates &&
+		test_path_is_file .git/hooks/post-update &&
 		>frotz &&
 		git add frotz &&
 		git commit -a -m initial &&
-- 
2.39.0.rc0
Next: Jiang Xin
Message 1 of 24 in “t1301: fix wrong template dir for git-init”
  1. 1/4 t1301: fix wrong template dir for git-initJiang Xin, Nov 27, 2022
  2. 2/4 t1301: use test_when_finished for cleanupJiang Xin, Nov 27, 2022
  3. Junio C HamanoNov 28, 2022
  4. 3/4 t1301: wrap the statements in the for loopJiang Xin, Nov 27, 2022
  5. Junio C HamanoNov 28, 2022
  6. Jiang XinNov 28, 2022
  7. Jiang XinNov 28, 2022
  8. 4/4 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 27, 2022
  9. Junio C HamanoNov 28, 2022
  10. Jiang XinNov 28, 2022
  11. 1/3 t1301: fix wrong template dir for git-initJiang Xin, Nov 28, 2022
  12. Ævar Arnfjörð BjarmasonNov 28, 2022
  13. Jiang XinNov 28, 2022
  14. Ævar Arnfjörð BjarmasonNov 28, 2022
  15. 2/3 t1301: use test_when_finished for cleanupJiang Xin, Nov 28, 2022
  16. 3/3 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 28, 2022
  17. Ævar Arnfjörð BjarmasonNov 28, 2022
  18. Jiang XinNov 28, 2022
  19. Junio C HamanoNov 29, 2022
  20. 0/3 t1301: various updatesJiang Xin, Nov 28, 2022
  21. 0/3 t1301: various updatesJiang Xin, Nov 29, 2022
  22. 1/3 t1301: fix wrong template dir for git-initJiang Xin, Nov 29, 2022
  23. 2/3 t1301: use test_when_finished for cleanupJiang Xin, Nov 29, 2022
  24. 3/3 t1301: do not change $CWD in "shared=all" test caseJiang Xin, Nov 29, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.