[PATCH v2 08/20] parse-options: drop leading space from '--git-completion-helper' output
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Aug 19, 2022, 16:03 UTC
- Message-ID
- <20220819160411.1791200-9-szeder.dev@gmail.com>
- In-Reply-To
- <20220819160411.1791200-1-szeder.dev@gmail.com>
The output of 'git <cmd> --git-completion-helper' always starts with a space, e.g.:
$ git config --git-completion-helper --global --system --local [...]
This doesn't matter for the completion script, because field splitting discards that space anyway.
However, later patches in this series will teach parse-options to handle subcommands, and subcommands will be included in the completion helper output as well. This will make the loop printing options (and subcommands) a tad more complex, so I wanted to test the result. The test would have to account for the presence of that leading space, which bugged my OCD, so let's get rid of it.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- parse-options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/parse-options.c b/parse-options.c index a0a2cf98fa..8748f88e6f 100644 --- a/parse-options.c +++ b/parse-options.c @@ -620,7 +620,8 @@ static int show_gitcomp(const struct option *opts, int show_all) suffix = "="; if (starts_with(opts->long_name, "no-")) nr_noopts++; - printf(" --%s%s", opts->long_name, suffix); + printf("%s--%s%s", opts == original_opts ? "" : " ", + opts->long_name, suffix); } show_negated_gitcomp(original_opts, show_all, -1); show_negated_gitcomp(original_opts, show_all, nr_noopts);
-- 2.37.2.817.g36f84ce71d