git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch-pack: make unexpected peek result non-fatal

From
JTJonathan Tan <jonathantanmy@google.com>
Date
May 17, 2022, 06:20 UTC
Message-ID
<20220517062035.3648639-1-jonathantanmy@google.com>
In-Reply-To
<xmqqr14t4fwf.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> We used to die unless READ_NORMAL was returned, so the code after
> packet_reader_peek() can rely on reader->line to be populated.  Now
> that code must handle cases where an earlier _peek() gave something
> other than READ_NORMAL and in such an error case reader->line points
> at NULL.  So any code that assumed reader->line was populated needs
> to be updated.
> 
> Makes sense.
Thanks for taking a look. Yes, that's correct.
Previous: Junio C Hamano
Message 3 of 3 in “fetch-pack: make unexpected peek result non-fatal”
  1. fetch-pack: make unexpected peek result non-fatalJonathan Tan, May 16, 2022
  2. Junio C HamanoMay 16, 2022
  3. Jonathan TanMay 17, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.