From: Jonathan Tan Date: Tue, 17 May 2022 06:20:34 GMT Subject: Re: [PATCH] fetch-pack: make unexpected peek result non-fatal Message-ID: <20220517062035.3648639-1-jonathantanmy@google.com> In-Reply-To: Junio C Hamano writes: > We used to die unless READ_NORMAL was returned, so the code after > packet_reader_peek() can rely on reader->line to be populated. Now > that code must handle cases where an earlier _peek() gave something > other than READ_NORMAL and in such an error case reader->line points > at NULL. So any code that assumed reader->line was populated needs > to be updated. > > Makes sense. Thanks for taking a look. Yes, that's correct.