[PATCH v3 3/3] tests: make the code more readable
- From
COGONI Guillaume <cogoni.guillaume@gmail.com>
- Date
- Feb 22, 2022, 21:54 UTC
- Message-ID
- <20220222215430.605254-4-cogoni.guillaume@gmail.com>
- In-Reply-To
- <20220222215430.605254-1-cogoni.guillaume@gmail.com>
Replace the parsing of the output of "ls -l" by test_path_is_symlink() and test_readlink().
Signed-off-by: COGONI Guillaume <cogoni.guillaume@gmail.com> Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@gmail.com> --- t/t3903-stash.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index a6ad52db9f..d5ecee4fcc 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -393,7 +393,8 @@ test_expect_success SYMLINKS 'stash file to symlink' ' test_path_is_file_not_symlink file && test bar = "$(cat file)" && git stash apply && - case "$(ls -l file)" in *" file -> file2") :;; *) false;; esac + test_path_is_symlink file && + test "$(test_readlink file)" = file2 ' test_expect_success SYMLINKS 'stash file to symlink (stage rm)' ' @@ -404,7 +405,8 @@ test_expect_success SYMLINKS 'stash file to symlink (stage rm)' ' test_path_is_file_not_symlink file && test bar = "$(cat file)" && git stash apply && - case "$(ls -l file)" in *" file -> file2") :;; *) false;; esac + test_path_is_symlink file && + test "$(test_readlink file)" = file2 ' test_expect_success SYMLINKS 'stash file to symlink (full stage)' ' @@ -416,7 +418,8 @@ test_expect_success SYMLINKS 'stash file to symlink (full stage)' ' test_path_is_file_not_symlink file && test bar = "$(cat file)" && git stash apply && - case "$(ls -l file)" in *" file -> file2") :;; *) false;; esac + test_path_is_symlink file && + test "$(test_readlink file)" = file2 ' # This test creates a commit with a symlink used for the following tests
-- 2.25.1