git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/2] git-p4: show progress as an integer

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Jan 4, 2022, 12:43 UTC
Message-ID
<20220104124307.2524-3-jholdsworth@nvidia.com>
In-Reply-To
<20220104124307.2524-1-jholdsworth@nvidia.com>

When importing files from Perforce, git-p4 periodically logs the progress of file transfers as a percentage. However, the value is printed as a float with an excessive number of decimal places.

For example a typical update might contain the following message:
Importing revision 12345 (26.199617677553135%)

This patch simply rounds the value down to the nearest integer percentage value, greatly improving readability.

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
Acked-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index 74834736fa..a625077b83 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -3637,7 +3637,8 @@ def importChanges(self, changes, origin_revision=0):
             self.updateOptionDict(description)
 
             if not self.silent:
-                sys.stdout.write("\rImporting revision %s (%s%%)" % (change, cnt * 100 / len(changes)))
+                sys.stdout.write("\rImporting revision %s (%d%%)" % (
+                    change, (cnt * 100) // len(changes)))
                 sys.stdout.flush()
             cnt = cnt + 1
 
-- 
2.34.1
Previous: Joel HoldsworthNext: Joel Holdsworth
Message 2 of 3 in “git-p4: improve formatting of numeric values”
  1. 0/2 git-p4: improve formatting of numeric valuesJoel Holdsworth, Jan 4, 2022
  2. 2/2 git-p4: show progress as an integerJoel Holdsworth, Jan 4, 2022
  3. 1/2 git-p4: print size values in appropriate unitsJoel Holdsworth, Jan 4, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.