git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] upload-pack.c: increase output buffer size

From
Jacob Vosmaer <jacob@gitlab.com>
Date
Dec 14, 2021, 19:46 UTC
Message-ID
<20211214194626.33814-1-jacob@gitlab.com>
In-Reply-To
<YbizfdGq+RSu9BGe@coredump.intra.peff.net>

Thank you Ævar and Peff for your comments on the previous iteration of this patch. I have made the buffer size fixed at the pktline maximum, and I have changed the storage of output_state from stack to heap.

As far as I can tell, all return paths from create_pack_file call "die", except the happy path. So I only free the heap-allocated output_state on the happy path. Is that OK, or should I use a "goto out" function shape?

Jacob Vosmaer (1):
  upload-pack.c: increase output buffer size
 upload-pack.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
-- 
2.33.0
Previous: Jeff KingNext: Jacob Vosmaer
Message 5 of 17 in “Make upload-pack pack write size configurable”
  1. 0/1 Make upload-pack pack write size configurableJacob Vosmaer, Dec 13, 2021
  2. 1/1 upload-pack.c: make output buffer size configurableJacob Vosmaer, Dec 13, 2021
  3. Ævar Arnfjörð BjarmasonDec 14, 2021
  4. Jeff KingDec 14, 2021
  5. 0/1 upload-pack.c: increase output buffer sizeJacob Vosmaer, Dec 14, 2021
  6. 1/1 upload-pack.c: increase output buffer sizeJacob Vosmaer, Dec 14, 2021
  7. Ævar Arnfjörð BjarmasonDec 14, 2021
  8. Jeff KingDec 15, 2021
  9. Junio C HamanoDec 15, 2021
  10. rsbecker@nexbridge.comDec 15, 2021
  11. Jacob VosmaerDec 15, 2021
  12. rsbecker@nexbridge.comDec 15, 2021
  13. Jacob VosmaerDec 15, 2021
  14. rsbecker@nexbridge.comDec 15, 2021
  15. Jeff KingDec 14, 2021
  16. Jacob VosmaerDec 14, 2021
  17. Jeff KingDec 14, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.