RE: [PATCH v2 1/1] upload-pack.c: increase output buffer size

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Dec 15, 2021, 19:59 UTC
Message-ID: <003001d7f1ee$48c88410$da598c30$@nexbridge.com>
In-Reply-To: <xmqqa6h16414.fsf@gitster.g>

On December 15, 2021 2:51 PM, Junio C Hamano wrote:

Show 8 quoted lines

> Jacob Vosmaer <jacob@gitlab.com> writes:
> 
> > When serving a fetch, git upload-pack copies data from a git
> > pack-objects stdout pipe to its stdout. This commit increases the size
> > of the buffer used for that copying from 8192 to 65515, the maximum
> > sideband-64k packet size.
> 
> Thanks.  I agree with others that extra configurability is not needed in

this

> case, and allocating this on the heap (as long as we correctly deallocate

it

> when we are done) is the right thing.

This is likely to break NonStop as our sideband packet size is less than 64K. -Randall