[PATCH 05/19] t5516: drop unnecessary subshell and command invocation
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Dec 9, 2021, 05:11 UTC
- Message-ID
- <20211209051115.52629-6-sunshine@sunshineco.com>
- In-Reply-To
- <20211209051115.52629-1-sunshine@sunshineco.com>
To create its "expect" file, this test pipes into `sort` the output of `git for-each-ref` and a copy of that same output but with a minor textual transformation applied. To do so, it employs a subshell and commands `cat` and `sed` even though the same result can be accomplished by `sed` alone (without a subshell).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> --- t/t5516-fetch-push.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index 8212ca56dc..d5e19b54af 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -1316,10 +1316,7 @@ test_expect_success 'fetch follows tags by default' ' git pull ../testrepo main && git tag -m "annotated" tag && git for-each-ref >tmp1 && - ( - cat tmp1 - sed -n "s|refs/heads/main$|refs/remotes/origin/main|p" tmp1 - ) | + sed -n "p; s|refs/heads/main$|refs/remotes/origin/main|p" tmp1 | sort -k 3 >../expect ) && git init dst &&
-- 2.34.1.307.g9b7440fafd