git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] object-file.c: LLP64 compatibility, upcast unity for left shift

From
Philip Oakley <philipoakley@iee.email>
Date
Nov 26, 2021, 11:36 UTC
Message-ID
<20211126113614.709-5-philipoakley@iee.email>
In-Reply-To
<20211126113614.709-1-philipoakley@iee.email>

Visual Studio reports C4334 "was 64-bit shift intended" warning because of size miss-match.

Promote unity to the matching type to fit with the assignment.
Signed-off-by: Philip Oakley <philipoakley@iee.email>
---
This cannot be applied to the maint-2.32 branch as the earlier René Scharfe
patch had been, because the original sha1-file.c, to which the backport
would apply, has been renamed in e5afd4449d (object-file.c: rename
from sha1-file.c, 2020-12-31) which was merged in 8b327f1784
(Merge branch 'ma/sha1-is-a-hash', 2021-01-15)
---
 object-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/object-file.c b/object-file.c
index c3d866a287..da8821cb91 100644
--- a/object-file.c
+++ b/object-file.c
@@ -2425,7 +2425,7 @@ struct oidtree *odb_loose_cache(struct object_directory *odb,
 	struct strbuf buf = STRBUF_INIT;
 	size_t word_bits = bitsizeof(odb->loose_objects_subdir_seen[0]);
 	size_t word_index = subdir_nr / word_bits;
-	size_t mask = 1u << (subdir_nr % word_bits);
+	size_t mask = (size_t)1u << (subdir_nr % word_bits);
 	uint32_t *bitmap;
 
 	if (subdir_nr < 0 ||
-- 
2.34.0.rc1.windows.1.4.ga126985b17
Previous: Philip OakleyNext: Philip Oakley
Message 2 of 12 in “Fix LLP64 `(size_t)1` compatibility VS C4334 warnings”
  1. 0/4 Fix LLP64 `(size_t)1` compatibility VS C4334 warningsPhilip Oakley, Nov 26, 2021
  2. 4/4 object-file.c: LLP64 compatibility, upcast unity for left shiftPhilip Oakley, Nov 26, 2021
  3. 1/4 mergesort.c: LLP64 compatibility, upcast unity for left shiftPhilip Oakley, Nov 26, 2021
  4. René ScharfeNov 27, 2021
  5. Philip OakleyNov 29, 2021
  6. 3/4 diffcore-delta.c: LLP64 compatibility, upcast unity for left shiftPhilip Oakley, Nov 26, 2021
  7. Derrick StoleeNov 29, 2021
  8. Philip OakleyNov 29, 2021
  9. 2/4 repack.c: LLP64 compatibility, upcast unity for left shiftPhilip Oakley, Nov 26, 2021
  10. Taylor BlauNov 30, 2021
  11. Philip OakleyNov 30, 2021
  12. Derrick StoleeNov 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.