[PATCH 2/4] repack.c: LLP64 compatibility, upcast unity for left shift

From: Philip Oakley <philipoakley@iee.email>
Date: Nov 26, 2021, 11:36 UTC
Message-ID: <20211126113614.709-3-philipoakley@iee.email>
In-Reply-To: <20211126113614.709-1-philipoakley@iee.email>

Visual Studio reports C4334 "was 64-bit shift intended" warning because of size miss-match.

Promote unity to the matching type to fit with the `&` operator.

Signed-off-by: Philip Oakley <philipoakley@iee.email>
---
 builtin/repack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/repack.c b/builtin/repack.c
index 0b2d1e5d82..6da66474fd 100644
--- a/builtin/repack.c
+++ b/builtin/repack.c
@@ -842,7 +842,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
 			fname_old = mkpathdup("%s-%s%s",
 					packtmp, item->string, exts[ext].name);
 
-			if (((uintptr_t)item->util) & (1 << ext)) {
+			if (((uintptr_t)item->util) & ((uintptr_t)1 << ext)) {
 				struct stat statbuffer;
 				if (!stat(fname_old, &statbuffer)) {
 					statbuffer.st_mode &= ~(S_IWUSR | S_IWGRP | S_IWOTH);

-- 
2.34.0.rc1.windows.1.4.ga126985b17