git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/5] remote: replace static variables with struct remote_state

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Nov 18, 2021, 17:51 UTC
Message-ID
<20211118175152.2716229-1-jonathantanmy@google.com>
In-Reply-To
<20211118005325.64971-1-chooglen@google.com>
Glen Choo <chooglen@google.com> writes:
Show 11 quoted lines
> This series aims to make the remotes subsystem work with non-the_repository,
> which will allow submodule remotes to be accessed in-process, rather than
> through child processes. This is accomplished by creating a struct remote_state
> and adding it to struct repository.
> 
> Thanks for the kind review, Jonathan. I've incorporated most of the feedback
> from v4, except squashing patches 2-4. My reasoning is that those changes are
> mechanical and keeping them separate makes it more obvious whether or not each
> step has been done correctly. However, I agree that they are just intermediate
> steps that touch the same lines, so I am happy to squash them if other reviewers
> prefer that.
Thanks. This patch series looks good to me.
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
Previous: Glen Choo
Message 7 of 7 in “remote: replace static variables with struct remote_state”
  1. 0/5 remote: replace static variables with struct remote_stateGlen Choo, Nov 18, 2021
  2. 1/5 t5516: add test case for pushing remote refspecsGlen Choo, Nov 18, 2021
  3. 2/5 remote: move static variables into per-repository structGlen Choo, Nov 18, 2021
  4. 3/5 remote: use remote_state parameter internallyGlen Choo, Nov 18, 2021
  5. 4/5 remote: remove the_repository->remote_state from static methodsGlen Choo, Nov 18, 2021
  6. 5/5 remote: die if branch is not found in repositoryGlen Choo, Nov 18, 2021
  7. Jonathan TanNov 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.