From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 18 Nov 2021 17:51:52 GMT
Subject: Re: [PATCH v5 0/5] remote: replace static variables with struct remote_state
Message-ID: <20211118175152.2716229-1-jonathantanmy@google.com>
In-Reply-To: <20211118005325.64971-1-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:
> This series aims to make the remotes subsystem work with non-the_repository,
> which will allow submodule remotes to be accessed in-process, rather than
> through child processes. This is accomplished by creating a struct remote_state
> and adding it to struct repository.
> 
> Thanks for the kind review, Jonathan. I've incorporated most of the feedback
> from v4, except squashing patches 2-4. My reasoning is that those changes are
> mechanical and keeping them separate makes it more obvious whether or not each
> step has been done correctly. However, I agree that they are just intermediate
> steps that touch the same lines, so I am happy to squash them if other reviewers
> prefer that.

Thanks. This patch series looks good to me.
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>