git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/7] fixup! reftable: add dump utility

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Aug 16, 2021, 01:15 UTC
Message-ID
<20210816011538.34199-5-carenas@gmail.com>
In-Reply-To
<20210816011538.34199-1-carenas@gmail.com>

avoid _XOPEN_SOURCE redefinition in alpine by making sure git-compat-util.h is included first (as recommended in CodingGuidelines) and therefore avoid:

  In file included from ./hash.h:4,
                   from reftable/dump.c:19:
  ./git-compat-util.h:147: warning: "_XOPEN_SOURCE" redefined
    147 | #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
        |
  In file included from /usr/include/unistd.h:8,
                   from reftable/reftable-writer.h:15,
                   from reftable/dump.c:14:
  /usr/include/features.h:16: note: this is the location of the previous definition
     16 | #define _XOPEN_SOURCE 700
        |
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
Using code contributed by Junio and only reusing the commit from my original
 reftable/dump.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/reftable/dump.c b/reftable/dump.c
index 668cfa8996..ef017701b6 100644
--- a/reftable/dump.c
+++ b/reftable/dump.c
@@ -6,6 +6,7 @@ license that can be found in the LICENSE file or at
 https://developers.google.com/open-source/licenses/bsd
 */
 
+#include "git-compat-util.h"
 #include "reftable-blocksource.h"
 #include "reftable-error.h"
 #include "reftable-merged.h"
-- 
2.33.0.rc2.476.g1b09a32a73
Previous: Carlo Marcelo Arenas BelónNext: Carlo Marcelo Arenas Belón
Message 11 of 14 in “hn/reftable "fixes" for OpenBSD”
  1. 0/3 hn/reftable "fixes" for OpenBSDCarlo Marcelo Arenas Belón, Aug 2, 2021
  2. 1/3 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 2, 2021
  3. 2/3 reftable: clarify zlib version dependencyCarlo Marcelo Arenas Belón, Aug 2, 2021
  4. 3/3 openbsd: allow reftable building with zlib 1.2.3Carlo Marcelo Arenas Belón, Aug 2, 2021
  5. 4/3 fixup! reftable: add dump utilityCarlo Marcelo Arenas Belón, Aug 4, 2021
  6. Junio C HamanoAug 4, 2021
  7. 0/7 hn/reftable "fixes" for BSDCarlo Marcelo Arenas Belón, Aug 16, 2021
  8. 1/7 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 16, 2021
  9. 2/7 reftable: clarify zlib version dependencyCarlo Marcelo Arenas Belón, Aug 16, 2021
  10. 3/7 openbsd: allow reftable building with zlib 1.2.3Carlo Marcelo Arenas Belón, Aug 16, 2021
  11. 4/7 fixup! reftable: add dump utilityCarlo Marcelo Arenas Belón, Aug 16, 2021
  12. 5/7 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 16, 2021
  13. 6/7 fixup! reftable: reftable file level testsCarlo Marcelo Arenas Belón, Aug 16, 2021
  14. 7/7 fixup! reftable: (de)serialization for the polymorphic record typeCarlo Marcelo Arenas Belón, Aug 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.