git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/7] reftable: clarify zlib version dependency

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Aug 16, 2021, 01:15 UTC
Message-ID
<20210816011538.34199-3-carenas@gmail.com>
In-Reply-To
<20210816011538.34199-1-carenas@gmail.com>

3541411189 (reftable: reading/writing blocks, 2021-07-20) add a comment explaining that a newer zlib version is required but being a little vague about the specifics

make sure the zlib version is mentioned to aid on deciding to enable or not the NO_UNCOMPRESS2 compatibility layer

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 reftable/block.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/reftable/block.c b/reftable/block.c
index 92f8e5abfa..eb5268dd3a 100644
--- a/reftable/block.c
+++ b/reftable/block.c
@@ -16,7 +16,9 @@ license that can be found in the LICENSE file or at
 #include <zlib.h>
 
 #ifdef NO_UNCOMPRESS2
-/* This is uncompress2, which is only available in zlib as of 2017.
+/*
+ * This is uncompress2, which is only available in zlib >= 1.2.9
+ * (released as of early 2017)
  */
 int uncompress2(Bytef *dest, uLongf *destLen, const Bytef *source,
 		uLong *sourceLen);
-- 
2.33.0.rc2.476.g1b09a32a73
Previous: Carlo Marcelo Arenas BelónNext: Carlo Marcelo Arenas Belón
Message 9 of 14 in “hn/reftable "fixes" for OpenBSD”
  1. 0/3 hn/reftable "fixes" for OpenBSDCarlo Marcelo Arenas Belón, Aug 2, 2021
  2. 1/3 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 2, 2021
  3. 2/3 reftable: clarify zlib version dependencyCarlo Marcelo Arenas Belón, Aug 2, 2021
  4. 3/3 openbsd: allow reftable building with zlib 1.2.3Carlo Marcelo Arenas Belón, Aug 2, 2021
  5. 4/3 fixup! reftable: add dump utilityCarlo Marcelo Arenas Belón, Aug 4, 2021
  6. Junio C HamanoAug 4, 2021
  7. 0/7 hn/reftable "fixes" for BSDCarlo Marcelo Arenas Belón, Aug 16, 2021
  8. 1/7 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 16, 2021
  9. 2/7 reftable: clarify zlib version dependencyCarlo Marcelo Arenas Belón, Aug 16, 2021
  10. 3/7 openbsd: allow reftable building with zlib 1.2.3Carlo Marcelo Arenas Belón, Aug 16, 2021
  11. 4/7 fixup! reftable: add dump utilityCarlo Marcelo Arenas Belón, Aug 16, 2021
  12. 5/7 fixup! Provide zlib's uncompress2 from compat/zlib-compat.cCarlo Marcelo Arenas Belón, Aug 16, 2021
  13. 6/7 fixup! reftable: reftable file level testsCarlo Marcelo Arenas Belón, Aug 16, 2021
  14. 7/7 fixup! reftable: (de)serialization for the polymorphic record typeCarlo Marcelo Arenas Belón, Aug 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.