Re: [PATCH] init: don't reset core.filemode on git-new-workdirs.

From: Madhu <enometh@meer.net>
Date: Jun 18, 2021, 04:18 UTC
Message-ID: <20210618.094806.1369340605245207462.enometh@meer.net>
In-Reply-To: <xmqqr1k64bmk.fsf@gitster.g>

I don't think this got any further attention? I notice git-2.32 still has the problem - in which case I re-commend my original patch. Regards ---Madhu

*  Junio C Hamano <gitster@pobox.com> <xmqqr1k64bmk.fsf@gitster.g>
Wrote on Mon, 22 Mar 2021 23:39:31 -0700

Show 20 quoted lines

> Madhu <enometh@meer.net> writes:
>> Avoiding the filemode check completely during reinit is ok with me
>> because it gave me wrong results.  I can't speak for the original
>> author of the code - if his intention was to do it explicitly as part
>> of "reinitialization".
>
> As the original author of the code, I know I meant filemode check to
> be done and redone upon reinitialization in 4f629539 (init-db: check
> template and repository format., 2005-11-25).
>
> But then when 75d24499 (git-init: autodetect core.symlinks,
> 2007-08-31) started to autodetect symbolic link support, I somehow
> ended up doing it only upon the repository creation.  Later,
> 2455406a (git-init: autodetect core.ignorecase, 2008-05-11) imitated
> to check case sensitivity in the same block, doing it only once.
>
> Either of these two commits would have been a good chance for us to
> realize that filemode check should be done the same way, but somehow
> nobody noticed X-<.
>