git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] xdiff/xmerge: simplify xdl_recs_copy_0

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 13, 2021, 22:58 UTC
Message-ID
<20210613225836.1009569-4-felipe.contreras@gmail.com>
In-Reply-To
<20210613225836.1009569-1-felipe.contreras@gmail.com>
Remove one unnecessary indentation level.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 xdiff/xmerge.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/xdiff/xmerge.c b/xdiff/xmerge.c
index ab3448ca88..b5b3f56f92 100644
--- a/xdiff/xmerge.c
+++ b/xdiff/xmerge.c
@@ -122,19 +122,19 @@ static int xdl_recs_copy_0(int use_orig, xdfenv_t *xe, int i, int count, int nee
 	for (i = 0; i < count; size += recs[i++]->size)
 		if (dest)
 			memcpy(dest + size, recs[i]->ptr, recs[i]->size);
-	if (add_nl) {
-		i = recs[count - 1]->size;
-		if (i == 0 || recs[count - 1]->ptr[i - 1] != '\n') {
-			if (needs_cr) {
-				if (dest)
-					dest[size] = '\r';
-				size++;
-			}
-
+	if (!add_nl)
+		return size;
+	i = recs[count - 1]->size;
+	if (i == 0 || recs[count - 1]->ptr[i - 1] != '\n') {
+		if (needs_cr) {
 			if (dest)
-				dest[size] = '\n';
+				dest[size] = '\r';
 			size++;
 		}
+
+		if (dest)
+			dest[size] = '\n';
+		size++;
 	}
 	return size;
 }
-- 
2.32.0
Previous: Felipe Contreras
Message 10 of 10 in “merge: cleanups and fix”
  1. 0/4 merge: cleanups and fixFelipe Contreras, Jun 13, 2021
  2. 4/4 xdiff/xmerge: fix chg0 initializationFelipe Contreras, Jun 13, 2021
  3. Elijah NewrenJun 14, 2021
  4. Felipe ContrerasJun 15, 2021
  5. Elijah NewrenJun 15, 2021
  6. 1/4 merge: simplify initializationFelipe Contreras, Jun 13, 2021
  7. Ævar Arnfjörð BjarmasonJun 15, 2021
  8. Felipe ContrerasJun 17, 2021
  9. 2/4 merge: fix Yoda conditionsFelipe Contreras, Jun 13, 2021
  10. 3/4 xdiff/xmerge: simplify xdl_recs_copy_0Felipe Contreras, Jun 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.