git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] merge: simplify initialization

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 13, 2021, 22:58 UTC
Message-ID
<20210613225836.1009569-2-felipe.contreras@gmail.com>
In-Reply-To
<20210613225836.1009569-1-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 builtin/merge-file.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/builtin/merge-file.c b/builtin/merge-file.c
index 06a2f90c48..0186f4156a 100644
--- a/builtin/merge-file.c
+++ b/builtin/merge-file.c
@@ -28,7 +28,7 @@ int cmd_merge_file(int argc, const char **argv, const char *prefix)
 	const char *names[3] = { NULL, NULL, NULL };
 	mmfile_t mmfs[3];
 	mmbuffer_t result = {NULL, 0};
-	xmparam_t xmp = {{0}};
+	xmparam_t xmp = { .level = XDL_MERGE_ZEALOUS_ALNUM };
 	int ret = 0, i = 0, to_stdout = 0;
 	int quiet = 0;
 	struct option options[] = {
@@ -48,10 +48,6 @@ int cmd_merge_file(int argc, const char **argv, const char *prefix)
 		OPT_END(),
 	};
 
-	xmp.level = XDL_MERGE_ZEALOUS_ALNUM;
-	xmp.style = 0;
-	xmp.favor = 0;
-
 	if (startup_info->have_repository) {
 		/* Read the configuration file */
 		git_config(git_xmerge_config, NULL);
-- 
2.32.0
Previous: Elijah NewrenNext: Ævar Arnfjörð Bjarmason
Message 6 of 10 in “merge: cleanups and fix”
  1. 0/4 merge: cleanups and fixFelipe Contreras, Jun 13, 2021
  2. 4/4 xdiff/xmerge: fix chg0 initializationFelipe Contreras, Jun 13, 2021
  3. Elijah NewrenJun 14, 2021
  4. Felipe ContrerasJun 15, 2021
  5. Elijah NewrenJun 15, 2021
  6. 1/4 merge: simplify initializationFelipe Contreras, Jun 13, 2021
  7. Ævar Arnfjörð BjarmasonJun 15, 2021
  8. Felipe ContrerasJun 17, 2021
  9. 2/4 merge: fix Yoda conditionsFelipe Contreras, Jun 13, 2021
  10. 3/4 xdiff/xmerge: simplify xdl_recs_copy_0Felipe Contreras, Jun 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.