git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/11] push: remove unused code in setup_push_upstream()

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 28, 2021, 20:10 UTC
Message-ID
<20210528201014.2175179-6-felipe.contreras@gmail.com>
In-Reply-To
<20210528201014.2175179-1-felipe.contreras@gmail.com>
Now it's not used for the simple mode.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 builtin/push.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/builtin/push.c b/builtin/push.c
index 73fe083682..0961826269 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -186,7 +186,7 @@ static const char message_detached_head_die[] =
 	   "    git push %s HEAD:<name-of-remote-branch>\n");
 
 static void setup_push_upstream(struct remote *remote, struct branch *branch,
-				int triangular, int simple)
+				int triangular)
 {
 	if (!branch)
 		die(_(message_detached_head_die), remote->name);
@@ -207,12 +207,6 @@ static void setup_push_upstream(struct remote *remote, struct branch *branch,
 		      "to update which remote branch."),
 		    remote->name, branch->name);
 
-	if (simple) {
-		/* Additional safety */
-		if (strcmp(branch->refname, branch->merge[0]->src))
-			die_push_simple(branch, remote);
-	}
-
 	refspec_appendf(&rs, "%s:%s", branch->refname, branch->merge[0]->src);
 }
 
@@ -271,7 +265,7 @@ static void setup_default_push_refspecs(struct remote *remote)
 		break;
 
 	case PUSH_DEFAULT_UPSTREAM:
-		setup_push_upstream(remote, branch, triangular, 0);
+		setup_push_upstream(remote, branch, triangular);
 		break;
 
 	case PUSH_DEFAULT_CURRENT:
-- 
2.32.0.rc0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 11 of 24 in “Unconvolutize push.default=simple”
  1. 00/11 Unconvolutize push.default=simpleFelipe Contreras, May 28, 2021
  2. 01/11 push: hedge code of default=simpleFelipe Contreras, May 28, 2021
  3. 02/11 push: move code to setup_push_simple()Felipe Contreras, May 28, 2021
  4. 03/11 push: reorganize setup_push_simple()Felipe Contreras, May 28, 2021
  5. Elijah NewrenMay 28, 2021
  6. Felipe ContrerasMay 28, 2021
  7. Elijah NewrenMay 28, 2021
  8. 04/11 push: simplify setup_push_simple()Felipe Contreras, May 28, 2021
  9. Elijah NewrenMay 28, 2021
  10. Felipe ContrerasMay 28, 2021
  11. 05/11 push: remove unused code in setup_push_upstream()Felipe Contreras, May 28, 2021
  12. 06/11 push: merge current and simpleFelipe Contreras, May 28, 2021
  13. 07/11 push: remove redundant checkFelipe Contreras, May 28, 2021
  14. 08/11 push: fix Yoda conditionFelipe Contreras, May 28, 2021
  15. 09/11 push: remove trivial functionFelipe Contreras, May 28, 2021
  16. 11/11 doc: push: explain default=simple correctlyFelipe Contreras, May 28, 2021
  17. Elijah NewrenMay 28, 2021
  18. Bagas SanjayaMay 29, 2021
  19. 10/11 push: flip !triangular for centralizedFelipe Contreras, May 28, 2021
  20. Elijah NewrenMay 28, 2021
  21. Felipe ContrerasMay 28, 2021
  22. Elijah NewrenMay 28, 2021
  23. Felipe ContrerasMay 28, 2021
  24. Elijah NewrenMay 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.