git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Refactor some prompts

From
Firmin Martin <firminmartin24@gmail.com>
Date
May 13, 2021, 21:41 UTC
Message-ID
<20210513214152.34792-1-firminmartin24@gmail.com>
As discussed in [1]: 
- The two instances of git_prompt in builtin/bisect--helper.c should be
replaced by git_read_line_interactively;
- The prompts using fgets in "git am -i" could also be refactored using that
helper function;
- It would be nice to add a comment which warns people to not use
git_prompt for regular prompts. 
This patch series addresses these points.
[1]: https://lore.kernel.org/git/20210506165102.123739-2-firminmartin24@gmail.com/
Firmin Martin (2):
  prompt.h: clarify the non-use of git_prompt
  builtin: use git_read_line_interactively to prompt
 builtin/am.c             | 14 +++++++-------
 builtin/bisect--helper.c | 15 ++++++++-------
 prompt.h                 | 10 ++++++++++
 3 files changed, 25 insertions(+), 14 deletions(-)
-- 
2.31.1.443.g67a420f573
Next: Firmin Martin
Message 1 of 7 in “Refactor some prompts”
  1. 0/2 Refactor some promptsFirmin Martin, May 13, 2021
  2. 1/2 prompt.h: clarify the non-use of git_promptFirmin Martin, May 13, 2021
  3. Junio C HamanoMay 13, 2021
  4. Junio C HamanoMay 13, 2021
  5. Jeff KingMay 15, 2021
  6. 2/2 builtin: use git_read_line_interactively to promptFirmin Martin, May 13, 2021
  7. Junio C HamanoMay 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.