As discussed in [1]:
- The two instances of git_prompt in builtin/bisect--helper.c should be
replaced by git_read_line_interactively;
- The prompts using fgets in "git am -i" could also be refactored using that
helper function;
- It would be nice to add a comment which warns people to not use
git_prompt for regular prompts.
This patch series addresses these points.
[1]: https://lore.kernel.org/git/20210506165102.123739-2-firminmartin24@gmail.com/
Firmin Martin (2):
prompt.h: clarify the non-use of git_prompt
builtin: use git_read_line_interactively to prompt
builtin/am.c | 14 +++++++-------
builtin/bisect--helper.c | 15 ++++++++-------
prompt.h | 10 ++++++++++
3 files changed, 25 insertions(+), 14 deletions(-)