Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Nov 18, 2020, 18:30 UTC
Message-ID: <20201118183022.GA8396@szeder.dev>
In-Reply-To: <nycvar.QRO.7.76.6.2011152252520.18437@tvgsbejvaqbjf.bet>

On Sun, Nov 15, 2020 at 11:08:40PM +0100, Johannes Schindelin wrote:

Show 21 quoted lines

> Hi Gábor,
> 
> On Fri, 13 Nov 2020, SZEDER Gábor wrote:
> 
> > In 't5310-pack-bitmaps.sh' two tests make sure that our pack bitmaps
> > are compatible with JGit's bitmaps.  Alas, not even the most recent
> > JGit version (5.9.0.202009080501-r) supports SHA256 yet, so when this
> > test script is run with GIT_TEST_DEFAULT_HASH=sha256 on a setup with
> > JGit installed in PATH, then these two tests fail.
> 
> I wonder whether there is a way to change the `JGIT` prereq in a way
> that automagically will recognize a (future) SHA256-enabled JGit?
> Something like
> 
> test_lazy_prereq JGIT '
> 	jgit --version &&
>         test_have_prereq !SHA1 ||
> 	test "$(git rev-list -n 1 HEAD)" = "$(jgit rev-list -n 1 HEAD)"
> '
> 
> What do you think?

I'm not sure. It is surely a substantial effort to fully support SHA256, and I suppose there will be JGit versions with only partial support. I'm worried that there will be versions that can already read SHA256 objects, but can't read/write SHA256 pack bitmaps, or can't transfer/negotiate SHA256 objects yet (for t5512), so even though they could fulfill such a prereq test above, the test would still fail.