git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Nov 13, 2020, 21:53 UTC
Message-ID
<20201113215307.20855-1-szeder.dev@gmail.com>

In 't5310-pack-bitmaps.sh' two tests make sure that our pack bitmaps are compatible with JGit's bitmaps. Alas, not even the most recent JGit version (5.9.0.202009080501-r) supports SHA256 yet, so when this test script is run with GIT_TEST_DEFAULT_HASH=sha256 on a setup with JGit installed in PATH, then these two tests fail.

Protect these two tests with the SHA1 prereq in order to skip them when testing with SHA256.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/t5310-pack-bitmaps.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
index 8318781d2b..1d40fcad39 100755
--- a/t/t5310-pack-bitmaps.sh
+++ b/t/t5310-pack-bitmaps.sh
@@ -277,7 +277,7 @@ test_expect_success 'pack with missing parent' '
 	git pack-objects --stdout --revs <revs >/dev/null
 '
 
-test_expect_success JGIT 'we can read jgit bitmaps' '
+test_expect_success JGIT,SHA1 'we can read jgit bitmaps' '
 	git clone --bare . compat-jgit.git &&
 	(
 		cd compat-jgit.git &&
@@ -287,7 +287,7 @@ test_expect_success JGIT 'we can read jgit bitmaps' '
 	)
 '
 
-test_expect_success JGIT 'jgit can read our bitmaps' '
+test_expect_success JGIT,SHA1 'jgit can read our bitmaps' '
 	git clone --bare . compat-us.git &&
 	(
 		cd compat-us.git &&
-- 
2.29.2.612.g41c40d3f73
Next: Taylor Blau
Message 1 of 9 in “t5310-pack-bitmaps: skip JGit tests with SHA256”
  1. t5310-pack-bitmaps: skip JGit tests with SHA256SZEDER Gábor, Nov 13, 2020
  2. Taylor BlauNov 13, 2020
  3. brian m. carlsonNov 13, 2020
  4. SZEDER GáborNov 15, 2020
  5. Johannes SchindelinNov 15, 2020
  6. SZEDER GáborNov 18, 2020
  7. Jeff KingNov 18, 2020
  8. Johannes SchindelinNov 19, 2020
  9. Jeff KingNov 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.