git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] rev-parse options for absolute or relative paths

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Nov 5, 2020, 03:20 UTC
Message-ID
<20201105032040.GB1332931@camp.crustytoothpaste.net>
In-Reply-To
<20201104230157.GH2774782@google.com>
On 2020-11-04 at 23:01:57, Emily Shaffer wrote:
Show 9 quoted lines
> Hiya, we took a look in the review club, but I'll try to keep it simple.
> 
> On Fri, Oct 09, 2020 at 07:15:09PM +0000, brian m. carlson wrote:
> > 
> > There are a bunch of different situations in which one would like to
> > have an absolute and canonical or a relative path from Git.
> 
> I think specifically you are interested in this situation:
> https://github.com/git-lfs/git-lfs/issues/4012
Yes, that's the case I'm interested in.
> I think this would have been useful to see in the cover letter :) There
> was a lot of "but why" during the review club meeting.

Sorry about that. When I'm sending patches to Git that benefit Git LFS, I want to be careful to build features that are generally applicable and don't just try to shove in features that benefit the project I maintain, so I'm often a little hesitant to mention my particular use case and try to let the patch stand on its own. I know that there are several competing projects in this space, and I want to be sensitive to not privileging my own just because I'm a frequent contributor.

I'll try to strike a better balance here in the future.
Show 7 quoted lines
> Also, there was some brief wondering: if this option is useful in 'git
> rev-parse', would it be useful in other commands too? I thought maybe it
> would be more useful as an arg to 'git' itself, but on inspection, not
> really - because you wouldn't be able to switch the format in the middle
> of a bunch of args, like you can now. The way it's written here,
> though, should mean a smooth transition to something like OPT__VERBOSE
> or OPT__QUIET if we discover lots of folks would find use.

Yeah, I think this could be a thing we add in the future, but I'm generally comfortable with this being just in rev-parse, since that's the command that folks tend to use when scripting, but we'll see if other folks think differently.

-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US
Previous: Emily ShafferNext: Johannes Schindelin
Message 12 of 13 in “rev-parse options for absolute or relative paths”
  1. 0/2 rev-parse options for absolute or relative pathsbrian m. carlson, Oct 9, 2020
  2. 2/2 rev-parse: add option for absolute or relative path formattingbrian m. carlson, Oct 9, 2020
  3. Johannes SchindelinNov 9, 2020
  4. brian m. carlsonNov 16, 2020
  5. 1/2 abspath: add a function to resolve paths with missing componentsbrian m. carlson, Oct 9, 2020
  6. Junio C HamanoOct 9, 2020
  7. brian m. carlsonOct 10, 2020
  8. Johannes SchindelinNov 9, 2020
  9. Johannes SchindelinNov 9, 2020
  10. brian m. carlsonNov 16, 2020
  11. Emily ShafferNov 4, 2020
  12. brian m. carlsonNov 5, 2020
  13. Johannes SchindelinNov 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.