git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] rev-parse options for absolute or relative paths

From
Emily Shaffer <emilyshaffer@google.com>
Date
Nov 4, 2020, 23:01 UTC
Message-ID
<20201104230157.GH2774782@google.com>
In-Reply-To
<20201009191511.267461-1-sandals@crustytoothpaste.net>
Hiya, we took a look in the review club, but I'll try to keep it simple.
On Fri, Oct 09, 2020 at 07:15:09PM +0000, brian m. carlson wrote:
> 
> There are a bunch of different situations in which one would like to
> have an absolute and canonical or a relative path from Git.

I think specifically you are interested in this situation: https://github.com/git-lfs/git-lfs/issues/4012

I think this would have been useful to see in the cover letter :) There was a lot of "but why" during the review club meeting.

Looking at the git-lfs issue in question, the problem seems to be "how to make sure the path Git gives me will match the path Go gives me" - and like you mentioned in the issue, there are two ways to fix it.

Also, there was some brief wondering: if this option is useful in 'git rev-parse', would it be useful in other commands too? I thought maybe it would be more useful as an arg to 'git' itself, but on inspection, not really - because you wouldn't be able to switch the format in the middle of a bunch of args, like you can now. The way it's written here, though, should mean a smooth transition to something like OPT__VERBOSE or OPT__QUIET if we discover lots of folks would find use.

Thanks for sending it. I'll try and do a detailed review of the patches themselves. To me, the concept seems sound.

 - Emily
Previous: brian m. carlsonNext: brian m. carlson
Message 11 of 13 in “rev-parse options for absolute or relative paths”
  1. 0/2 rev-parse options for absolute or relative pathsbrian m. carlson, Oct 9, 2020
  2. 2/2 rev-parse: add option for absolute or relative path formattingbrian m. carlson, Oct 9, 2020
  3. Johannes SchindelinNov 9, 2020
  4. brian m. carlsonNov 16, 2020
  5. 1/2 abspath: add a function to resolve paths with missing componentsbrian m. carlson, Oct 9, 2020
  6. Junio C HamanoOct 9, 2020
  7. brian m. carlsonOct 10, 2020
  8. Johannes SchindelinNov 9, 2020
  9. Johannes SchindelinNov 9, 2020
  10. brian m. carlsonNov 16, 2020
  11. Emily ShafferNov 4, 2020
  12. brian m. carlsonNov 5, 2020
  13. Johannes SchindelinNov 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.