git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 04/10] completion: bash: get rid of any non-append code

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 4, 2020, 17:47 UTC
Message-ID
<20201104174716.783348-5-felipe.contreras@gmail.com>
In-Reply-To
<20201104174716.783348-1-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 80701749fa..9f384698f2 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -315,12 +315,6 @@ __gitcompappend ()
 	done
 }
 
-__gitcompadd ()
-{
-	COMPREPLY=()
-	__gitcompappend "$@"
-}
-
 # Generates completion reply, appending a space to possible completion words,
 # if necessary.
 # It accepts 1 to 4 arguments:
@@ -448,7 +442,7 @@ __gitcomp_file_direct ()
 {
 	local IFS=$'\n'
 
-	COMPREPLY=($1)
+	COMPREPLY+=($1)
 
 	# use a hack to enable file mode in bash < 4
 	compopt -o filenames +o nospace 2>/dev/null ||
@@ -471,7 +465,7 @@ __gitcomp_file ()
 	# since tilde expansion is not applied.
 	# This means that COMPREPLY will be empty and Bash default
 	# completion will be used.
-	__gitcompadd "$1" "${2-}" "${3-$cur}" ""
+	__gitcompappend "$1" "${2-}" "${3-$cur}" ""
 
 	# use a hack to enable file mode in bash < 4
 	compopt -o filenames +o nospace 2>/dev/null ||
-- 
2.29.2
Previous: Felipe ContrerasNext: Felipe Contreras
Message 5 of 11 in “completion: bash: general cleanups and reorganizations”
  1. 00/10 completion: bash: general cleanups and reorganizationsFelipe Contreras, Nov 4, 2020
  2. 01/10 test: completion: add run_func() helperFelipe Contreras, Nov 4, 2020
  3. 02/10 completion: bash: remove non-append functionalityFelipe Contreras, Nov 4, 2020
  4. 03/10 completion: bash: get rid of _append() functionsFelipe Contreras, Nov 4, 2020
  5. 04/10 completion: bash: get rid of any non-append codeFelipe Contreras, Nov 4, 2020
  6. 05/10 completion: bash: do not modify COMP_WORDBREAKSFelipe Contreras, Nov 4, 2020
  7. 06/10 completion: bash: simplify _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  8. 07/10 completion: bash: refactor _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  9. 09/10 completion: bash: trivial cleanupFelipe Contreras, Nov 4, 2020
  10. 08/10 completion: bash: cleanup _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  11. 10/10 completion: bash: move _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.