git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/10] completion: bash: trivial cleanup

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 4, 2020, 17:47 UTC
Message-ID
<20201104174716.783348-10-felipe.contreras@gmail.com>
In-Reply-To
<20201104174716.783348-1-felipe.contreras@gmail.com>
The most typical case first (COMP_WORDBREAKS contains our wanted words).
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3666fba8ca..b4e6f82c66 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -207,9 +207,7 @@ _get_comp_words_by_ref ()
 	# Which word separators to exclude?
 	exclude="${COMP_WORDBREAKS//[^=:]}"
 	cword=$COMP_CWORD
-	if [ -z "$exclude" ]; then
-		words=("${COMP_WORDS[@]}")
-	else
+	if [ -n "$exclude" ]; then
 		# List of word completion separators has shrunk;
 		# re-assemble words to complete.
 		for ((i=0, j=0; i < ${#COMP_WORDS[@]}; i++, j++)); do
@@ -244,6 +242,8 @@ _get_comp_words_by_ref ()
 				cword=$j
 			fi
 		done
+	else
+		words=("${COMP_WORDS[@]}")
 	fi
 
 	cur=${words[cword]}
-- 
2.29.2
Previous: Felipe ContrerasNext: Felipe Contreras
Message 9 of 11 in “completion: bash: general cleanups and reorganizations”
  1. 00/10 completion: bash: general cleanups and reorganizationsFelipe Contreras, Nov 4, 2020
  2. 01/10 test: completion: add run_func() helperFelipe Contreras, Nov 4, 2020
  3. 02/10 completion: bash: remove non-append functionalityFelipe Contreras, Nov 4, 2020
  4. 03/10 completion: bash: get rid of _append() functionsFelipe Contreras, Nov 4, 2020
  5. 04/10 completion: bash: get rid of any non-append codeFelipe Contreras, Nov 4, 2020
  6. 05/10 completion: bash: do not modify COMP_WORDBREAKSFelipe Contreras, Nov 4, 2020
  7. 06/10 completion: bash: simplify _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  8. 07/10 completion: bash: refactor _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  9. 09/10 completion: bash: trivial cleanupFelipe Contreras, Nov 4, 2020
  10. 08/10 completion: bash: cleanup _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020
  11. 10/10 completion: bash: move _get_comp_words_by_ref()Felipe Contreras, Nov 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.