Re: Segfault in git when using git logs

From: Jeff King <peff@peff.net>
Date: Nov 4, 2020, 13:31 UTC
Message-ID: <20201104133129.GA3030480@coredump.intra.peff.net>
In-Reply-To: <xmqqimamqjhl.fsf@gitster.c.googlers.com>

On Tue, Nov 03, 2020 at 12:21:42PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> >> So something like this won't harm VS Code more than we currently do,
> >> while telling users what is wrong with their command line?
> >
> > Yeah, I was wondering if we'd want the patch you sent, or if we should
> > turn those die() calls into warning() and disable the flags up front.
> [...]
> >> diff --git c/builtin/log.c w/builtin/log.c

Since we now have identified the caller that was passing in the bogus options, and it has already been fixed, I'm inclined to say we should go with your die() patch from earlier (modulo the pathspec.nr fixup) and call it done.

Do you want to roll that up with a commit message?

-Peff