Re: Segfault in git when using git logs

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 3, 2020, 18:46 UTC
Message-ID: <0581272e-6ad2-42d9-0196-b804ee304619@gmail.com>
In-Reply-To: <CAMsWJsyPVQWV++gc2YJriEOEWBELa_xj2G0NWFMSgNYt47swiQ@mail.gmail.com>

On 11/2/2020 8:59 AM, Sathyajith Bhat wrote:

> Anything else you want to add:

Hi Sathyajith,

It seems like others have some good approaches to handling this segfault and making sure we find the right balance between supporting existing behavior and helping callers who might be using this command incorrectly.

> Note that I am not calling the git log commands directly, my editor VS
> Code was repeatedly crashing and I searched in syslog and found this
> error.

I started filling out an issue on the VS Code GitHub repo so they could perhaps fix their usage of "git log" in this case. However, I started searching their code for where they might be executing the command, and I didn't find anything!

Is it possible that you have an extension that enables Git history commands like this?

The VS Code bug report issue template [1] has this bit of advice to find out if an extension is at fault:

> <!-- Launch with `code --disable-extensions` to check. -->
> Does this issue occur when all extensions are disabled?: Yes/No

[1] https://github.com/microsoft/vscode/issues/new?template=bug_report.md

Could you re-launch your editor with "--disable-extensions" to see if this is reproduced? Also, which extensions do you have installed that might be adding Git command calls? We might need to find the extension authors instead of the core editor team.

Thanks, -Stolee