git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/7] p7519-fsmonitor: refactor to avoid code duplication

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 20, 2020, 02:43 UTC
Message-ID
<20201020024329.GE54484@nand.local>
In-Reply-To
<b38f2984f93488d6582eff4865d6d5293491ce60.1603147657.git.gitgitgadget@gmail.com>
On Mon, Oct 19, 2020 at 10:47:36PM +0000, Nipunn Koorapati via GitGitGadget wrote:
Show 6 quoted lines
> From: Nipunn Koorapati <nipunn@dropbox.com>
>
> Much of the benchmark code is redundant. This is
> easier to understand and edit.
>
> Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
Much easier to read, thank you for taking the time to simplify the code.

I know that this is maybe more review than you were hoping for, but I think it's been worth it and the series is in an even better state than when you started.

  Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Nipunn Koorapati via GitGitGadgetNext: Nipunn Koorapati via GitGitGadget
Message 41 of 52 in “use fsmonitor data in git diff eliminating O(num_files) calls to lstat”
  1. 0/4 use fsmonitor data in git diff eliminating O(num_files) calls to lstatNipunn Koorapati via GitGitGadget, Oct 17, 2020
  2. 1/4 fsmonitor: use fsmonitor data in `git diff`Alex Vandiver via GitGitGadget, Oct 17, 2020
  3. Junio C HamanoOct 17, 2020
  4. Nipunn KoorapatiOct 18, 2020
  5. Taylor BlauOct 18, 2020
  6. Junio C HamanoOct 18, 2020
  7. Taylor BlauOct 18, 2020
  8. Junio C HamanoOct 19, 2020
  9. Taylor BlauOct 19, 2020
  10. Nipunn KoorapatiOct 19, 2020
  11. 2/4 t/perf/README: elaborate on output formatNipunn Koorapati via GitGitGadget, Oct 17, 2020
  12. 4/4 t/perf: add fsmonitor perf test for git diffNipunn Koorapati via GitGitGadget, Oct 17, 2020
  13. Junio C HamanoOct 17, 2020
  14. 3/4 t/perf/p7519-fsmonitor.sh: warm cache on first git statusNipunn Koorapati via GitGitGadget, Oct 17, 2020
  15. Taylor BlauOct 18, 2020
  16. 0/4 use fsmonitor data in git diff eliminating O(num_files) calls to lstatNipunn Koorapati via GitGitGadget, Oct 19, 2020
  17. 1/4 fsmonitor: use fsmonitor data in `git diff`Alex Vandiver via GitGitGadget, Oct 19, 2020
  18. 2/4 t/perf/README: elaborate on output formatNipunn Koorapati via GitGitGadget, Oct 19, 2020
  19. 3/4 t/perf/p7519-fsmonitor.sh: warm cache on first git statusNipunn Koorapati via GitGitGadget, Oct 19, 2020
  20. 4/4 t/perf: add fsmonitor perf test for git diffNipunn Koorapati via GitGitGadget, Oct 19, 2020
  21. Taylor BlauOct 19, 2020
  22. Taylor BlauOct 19, 2020
  23. Nipunn KoorapatiOct 19, 2020
  24. Taylor BlauOct 19, 2020
  25. Nipunn KoorapatiOct 19, 2020
  26. 0/7 use fsmonitor data in git diff eliminating O(num_files) calls to lstatNipunn Koorapati via GitGitGadget, Oct 19, 2020
  27. 3/7 t/perf/p7519-fsmonitor.sh: warm cache on first git statusNipunn Koorapati via GitGitGadget, Oct 19, 2020
  28. 1/7 fsmonitor: use fsmonitor data in `git diff`Alex Vandiver via GitGitGadget, Oct 19, 2020
  29. 2/7 t/perf/README: elaborate on output formatNipunn Koorapati via GitGitGadget, Oct 19, 2020
  30. 5/7 perf lint: check test-lint-shell-syntax in perf testsNipunn Koorapati via GitGitGadget, Oct 19, 2020
  31. Taylor BlauOct 20, 2020
  32. Junio C HamanoOct 20, 2020
  33. Taylor BlauOct 20, 2020
  34. Nipunn KoorapatiOct 20, 2020
  35. Nipunn KoorapatiOct 20, 2020
  36. 7/7 p7519-fsmonitor: add a git add benchmarkNipunn Koorapati via GitGitGadget, Oct 19, 2020
  37. Nipunn KoorapatiOct 19, 2020
  38. Taylor BlauOct 20, 2020
  39. 4/7 t/perf: add fsmonitor perf test for git diffNipunn Koorapati via GitGitGadget, Oct 19, 2020
  40. 6/7 p7519-fsmonitor: refactor to avoid code duplicationNipunn Koorapati via GitGitGadget, Oct 19, 2020
  41. Taylor BlauOct 20, 2020
  42. 0/7 use fsmonitor data in git diff eliminating O(num_files) calls to lstatNipunn Koorapati via GitGitGadget, Oct 20, 2020
  43. 1/7 fsmonitor: use fsmonitor data in `git diff`Alex Vandiver via GitGitGadget, Oct 20, 2020
  44. 2/7 t/perf/README: elaborate on output formatNipunn Koorapati via GitGitGadget, Oct 20, 2020
  45. 6/7 p7519-fsmonitor: refactor to avoid code duplicationNipunn Koorapati via GitGitGadget, Oct 20, 2020
  46. 3/7 t/perf/p7519-fsmonitor.sh: warm cache on first git statusNipunn Koorapati via GitGitGadget, Oct 20, 2020
  47. 5/7 perf lint: add make test-lint to perf testsNipunn Koorapati via GitGitGadget, Oct 20, 2020
  48. Taylor BlauOct 20, 2020
  49. Nipunn KoorapatiOct 20, 2020
  50. Taylor BlauOct 20, 2020
  51. 4/7 t/perf: add fsmonitor perf test for git diffNipunn Koorapati via GitGitGadget, Oct 20, 2020
  52. 7/7 p7519-fsmonitor: add a git add benchmarkNipunn Koorapati via GitGitGadget, Oct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.