Re: [PATCH v3 7/7] p7519-fsmonitor: add a git add benchmark

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 20, 2020, 02:40 UTC
Message-ID: <20201020024018.GD54484@nand.local>
In-Reply-To: <d392a523f239f92f1b47ec1a96885f69fdc6d8b4.1603147657.git.gitgitgadget@gmail.com>

On Mon, Oct 19, 2020 at 10:47:37PM +0000, Nipunn Koorapati via GitGitGadget wrote:

Show 6 quoted lines

> From: Nipunn Koorapati <nipunn@dropbox.com>
>
> Test                                                                     v2.29.0-rc1       this tree
> -----------------------------------------------------------------------------------------------------------------
> [...]
> 7519.22: add (fsmonitor=)                                                2.26(1.46+1.49)   2.27(1.42+1.55) +0.4%

Good; no huge slow-down here. Thanks for checking!

Show 22 quoted lines

> Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
> ---
>  t/perf/p7519-fsmonitor.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
> index 75a0cef01d..fb20fe0937 100755
> --- a/t/perf/p7519-fsmonitor.sh
> +++ b/t/perf/p7519-fsmonitor.sh
> @@ -169,6 +169,10 @@ test_fsmonitor_suite() {
>  	test_perf_w_drop_caches "diff -- 10000_files (fsmonitor=$INTEGRATION_SCRIPT)" '
>  		git diff -- 10000_files
>  	'
> +
> +	test_perf_w_drop_caches "add (fsmonitor=$INTEGRATION_SCRIPT)" '
> +		git add  --all
> +	'
>  }
>
>  test_fsmonitor_suite
> --
> gitgitgadget

  Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor