git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-import: remove duplicated option-parsing line

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 17, 2020, 23:08 UTC
Message-ID
<20201017230840.GH490427@camp.crustytoothpaste.net>
In-Reply-To
<20201015193411.GA1130491@coredump.intra.peff.net>
On 2020-10-15 at 19:34:11, Jeff King wrote:
Show 6 quoted lines
> Commit 1bdca81641 (fast-import: add options for rewriting submodules,
> 2020-02-22) accidentally added two lines parsing the option
> "rewrite-submodules-from". This didn't do anything in practice, because
> they're in an if/else chain and so the second one can never trigger.
> 
> Signed-off-by: Jeff King <peff@peff.net>
This seems clearly correct.
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US
Previous: Junio C Hamano
Message 3 of 3 in “fast-import: remove duplicated option-parsing line”
  1. fast-import: remove duplicated option-parsing lineJeff King, Oct 15, 2020
  2. Junio C HamanoOct 16, 2020
  3. brian m. carlsonOct 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.