From: brian m. carlson Date: Sat, 17 Oct 2020 23:08:40 GMT Subject: Re: [PATCH] fast-import: remove duplicated option-parsing line Message-ID: <20201017230840.GH490427@camp.crustytoothpaste.net> In-Reply-To: <20201015193411.GA1130491@coredump.intra.peff.net> On 2020-10-15 at 19:34:11, Jeff King wrote: > Commit 1bdca81641 (fast-import: add options for rewriting submodules, > 2020-02-22) accidentally added two lines parsing the option > "rewrite-submodules-from". This didn't do anything in practice, because > they're in an if/else chain and so the second one can never trigger. > > Signed-off-by: Jeff King This seems clearly correct. -- brian m. carlson (he/him or they/them) Houston, Texas, US