Re: [PATCH] t7518: fix flaky grep invocation

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 17, 2020, 00:08 UTC
Message-ID: <20201017000838.GA2211921@nand.local>
In-Reply-To: <pull.884.git.git.1602891594738.gitgitgadget@gmail.com>

Hi Elijah,

On Fri, Oct 16, 2020 at 11:39:54PM +0000, Elijah Newren via GitGitGadget wrote:

Show 8 quoted lines

> From: Elijah Newren <newren@gmail.com>
>
> t7518.1 added in commit 862e80a413 ("ident: handle NULL email when
> complaining of empty name", 2017-02-23), was trying to make sure that
> the test with an empty ident did not segfault and did not result in
> glibc quiety translating a NULL pointer into a name of "(null)".  It did
> the latter by ensuring that a grep for "null" didn't appear in the
> output, but on one automatic CI run I observed the following output:

:-). I have always been surprised by glibc's behavior here; I'd almost always rather have a segfault than silently turning a NULL pointer into "(null)" when formatted with "%s".

Show 5 quoted lines

> fatal: empty ident name (for <runner@fv-az128-670.gcliasfzo2nullsdbrimjtbyhg.cx.internal.cloudapp.net>) not allowed
>
> Note that 'null' appears as a substring of the domain name, found
> within 'gcliasfzo2nullsdbrimjtbyhg'.  Tighten the test by searching for
> "(null)" rather than "null".

Yep; that sounds like a straightforward fix that will make this test non-flaky.

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor