From: Taylor Blau Date: Sat, 17 Oct 2020 00:08:38 GMT Subject: Re: [PATCH] t7518: fix flaky grep invocation Message-ID: <20201017000838.GA2211921@nand.local> In-Reply-To: Hi Elijah, On Fri, Oct 16, 2020 at 11:39:54PM +0000, Elijah Newren via GitGitGadget wrote: > From: Elijah Newren > > t7518.1 added in commit 862e80a413 ("ident: handle NULL email when > complaining of empty name", 2017-02-23), was trying to make sure that > the test with an empty ident did not segfault and did not result in > glibc quiety translating a NULL pointer into a name of "(null)". It did > the latter by ensuring that a grep for "null" didn't appear in the > output, but on one automatic CI run I observed the following output: :-). I have always been surprised by glibc's behavior here; I'd almost always rather have a segfault than silently turning a NULL pointer into "(null)" when formatted with "%s". > fatal: empty ident name (for ) not allowed > > Note that 'null' appears as a substring of the domain name, found > within 'gcliasfzo2nullsdbrimjtbyhg'. Tighten the test by searching for > "(null)" rather than "null". Yep; that sounds like a straightforward fix that will make this test non-flaky. Reviewed-by: Taylor Blau Thanks, Taylor