git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] index-pack: stop mentioning find_unresolved_deltas()

From
Jeff King <peff@peff.net>
Date
Oct 7, 2020, 18:19 UTC
Message-ID
<20201007181956.GC1976631@coredump.intra.peff.net>
In-Reply-To
<20201007181708.GA222564@coredump.intra.peff.net>

A comment mentions that we may free cached delta bases via find_unresolved_deltas(), but that function went away in f08cbf60fe (index-pack: make quantum of work smaller, 2020-09-08). Its call to prune_base_data() was moved into threaded_second_pass(), so just refer to that.

Signed-off-by: Jeff King <peff@peff.net>
---
 builtin/index-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index f8f1b48e56..e36f05f7a3 100644
--- a/builtin/index-pack.c
+++ b/builtin/index-pack.c
@@ -898,7 +898,7 @@ static void sha1_object(const void *data, struct object_entry *obj_entry,
  * parents, possibly up to the top base.
  *
  * All deflated objects here are subject to be freed if we exceed
- * delta_base_cache_limit, just like in find_unresolved_deltas(), we
+ * delta_base_cache_limit, just like in threaded_second_pass(), we
  * just need to make sure the last node is not freed.
  */
 static void *get_base_data(struct base_data *c)
-- 
2.29.0.rc0.520.gccaf68d5cd
Previous: Jonathan TanNext: Jonathan Tan
Message 15 of 21 in “[ANNOUNCE] Git v2.29.0-rc0”
  1. Junio C HamanoOct 5, 2020
  2. Bryan TurnerOct 5, 2020
  3. Randall S. BeckerOct 5, 2020
  4. Martin ÅgrenOct 6, 2020
  5. Junio C HamanoOct 6, 2020
  6. Ævar Arnfjörð BjarmasonOct 7, 2020
  7. Jeff KingOct 7, 2020
  8. Jeff KingOct 7, 2020
  9. Junio C HamanoOct 7, 2020
  10. 0/3 jt/threaded-inex-pack leftoversJeff King, Oct 7, 2020
  11. 1/3 index-pack: restore "resolving deltas" progress meterJeff King, Oct 7, 2020
  12. Junio C HamanoOct 7, 2020
  13. 2/3 index-pack: drop type_cas mutexJeff King, Oct 7, 2020
  14. Jonathan TanOct 7, 2020
  15. 3/3 index-pack: stop mentioning find_unresolved_deltas()Jeff King, Oct 7, 2020
  16. Jonathan TanOct 7, 2020
  17. Jeff KingOct 7, 2020
  18. index-pack: make get_base_data() comment clearerJonathan Tan, Oct 7, 2020
  19. Junio C HamanoOct 7, 2020
  20. Philippe BlainOct 7, 2020
  21. Randall S. BeckerOct 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.