[PATCH 0/3] jt/threaded-inex-pack leftovers

From: Jeff King <peff@peff.net>
Date: Oct 7, 2020, 18:17 UTC
Message-ID: <20201007181708.GA222564@coredump.intra.peff.net>
In-Reply-To: <xmqqlfgi2axr.fsf@gitster.c.googlers.com>

On Wed, Oct 07, 2020 at 10:38:40AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> > That _seems_ to work fine, but I'm not sure why it was removed in the
> > first place (for a good reason, or simply as an accident when rewriting
> > the variable declarations at the top of the loop?).
> 
> The above looks like an obvious and trivial fix to go back closer to
> the original.

Yeah. I'd still like to get an ack from Jonathan, but having looked at it more deeply, I'm pretty sure it's the right thing.

Show 6 quoted lines

> We seem to have removed find_unresolved_deltas() helper function in
> that series, but there remains a mention to it in a comment, which
> we would probably should rethink (it just may be the matter of
> removing the mention, or if "just like in ..." may have been the
> last example of doing what the comment suggests all code to do, it
> may reveal a need for larger clean-up---I dunno).

I think the code just moved around and we can update the reference, though I admit I haven't fully thought through whether there are any other subtleties.

I also noticed one other small cleanup related to the series. So here are a few patches on top of jt/threaded-index-pack.

  [1/3]: index-pack: restore "resolving deltas" progress meter
  [2/3]: index-pack: drop type_cas mutex
  [3/3]: index-pack: stop mentioning find_unresolved_deltas()

 builtin/index-pack.c  | 12 +++++-------
 t/t5302-pack-index.sh |  7 +++++++
 2 files changed, 12 insertions(+), 7 deletions(-)

-Peff