Re: [PATCH v2 5/8] shortlog: de-duplicate trailer values

From: Jeff King <peff@peff.net>
Date: Sep 28, 2020, 03:19 UTC
Message-ID: <20200928031921.GB3059492@coredump.intra.peff.net>
In-Reply-To: <xmqqh7rjnf42.fsf@gitster.c.googlers.com>

On Sun, Sep 27, 2020 at 01:23:25PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > The current documentation is vague about what happens with
> > --group=trailer:signed-off-by when we see a commit with:
> >
> >   Signed-off-by: One
> >   Signed-off-by: Two
> >   Signed-off-by: One
> >
> > We clearly should credit both "One" and "Two", but should "One" get
> > credited twice? The current code does so, but mostly because that was
> > the easiest thing to do.
> 
> I thought that "the current documentation" as of step 4/8 were quite
> clear about double counting ;-).

It was clear to me that the commit would be counted at least twice: once for the "one" bucket and once for the "two" bucket, but not that it would count twice for the "two" bucket. Or at least, I didn't think of this issue at all back when I wrote the original patch long ago, and only noticed the problem when I revisited it. :)

Anyway, I think the semantics at the end of the series are quite sensible.

-Peff