Re: [PATCH 2/8] shortlog: refactor committer/author grouping

From: Jeff King <peff@peff.net>
Date: Sep 27, 2020, 08:08 UTC
Message-ID: <20200927080846.GD1286220@coredump.intra.peff.net>
In-Reply-To: <20200927080345.GB1286220@coredump.intra.peff.net>

On Sun, Sep 27, 2020 at 04:03:45AM -0400, Jeff King wrote:

Show 13 quoted lines

> but that's pretty lengthy. We could also reword the whole thing as:
> 
>   --group=<type>::
>           Collect and collate values of type `<type>`; if no `--group`
> 	  option is given, the default is `author`:
>    - `author`, commits are grouped by author
>    - `committer`, commits are grouped by committer (the same as `-c`)
> 
> I'm not sure if that's clearer or not. The first sentence seems a bit
> opaque, but I'm not sure how to improve it.
> 
> For now (and what plan to send out in v2), I'll take your suggestion to
> just drop the phrase.

OK, I lied. After reading your other email, I ended up with:

  --group=<type>::
          Group commits based on `<type>`. If no `--group` option is
          specified, the default is `author`. `<type>` is one of:
  +
   - `author`, commits are grouped by author
   - `committer`, commits are grouped by committer (the same as `-c`)

  -c::
  --committer::
          This is an alias for `--group=committer`.

which I think works by itself, and extends nicely to trailers.

-Peff