git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-p4: use HEAD~$n to find parent commit for unshelve

From
Luke Diamand <luke@diamand.org>
Date
Sep 19, 2020, 08:54 UTC
Message-ID
<20200919085441.7621-3-luke@diamand.org>
In-Reply-To
<20200919085441.7621-2-luke@diamand.org>
Found-by: Liu Xuhui (Jackson) <Xuhui.Liu@amd.com>
Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py           | 2 +-
 t/t9832-unshelve.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index ca79dc0900..4433ca53de 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -4237,7 +4237,7 @@ def findLastP4Revision(self, starting_point):
         """
 
         for parent in (range(65535)):
-            log = extractLogMessageFromGitCommit("{0}^{1}".format(starting_point, parent))
+            log = extractLogMessageFromGitCommit("{0}~{1}".format(starting_point, parent))
             settings = extractSettingsGitLog(log)
             if 'change' in settings:
                 return settings
diff --git a/t/t9832-unshelve.sh b/t/t9832-unshelve.sh
index feda4499dd..7194fb2855 100755
--- a/t/t9832-unshelve.sh
+++ b/t/t9832-unshelve.sh
@@ -80,7 +80,7 @@ EOF
 	)
 '
 
-test_expect_failure 'update shelved changelist and re-unshelve' '
+test_expect_success 'update shelved changelist and re-unshelve' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$cli" &&
-- 
2.28.0
Previous: Luke DiamandNext: Eric Sunshine
Message 3 of 5 in “git-p4: unshelve uses HEAD^n, not HEAD~n”
  1. 0/2 git-p4: unshelve uses HEAD^n, not HEAD~nLuke Diamand, Sep 19, 2020
  2. 1/2 git-p4 unshelve: adding a commit breaks git-p4 unshelveLuke Diamand, Sep 19, 2020
  3. 2/2 git-p4: use HEAD~$n to find parent commit for unshelveLuke Diamand, Sep 19, 2020
  4. Eric SunshineSep 20, 2020
  5. Eric SunshineSep 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.