git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-p4 unshelve: adding a commit breaks git-p4 unshelve

From
Luke Diamand <luke@diamand.org>
Date
Sep 19, 2020, 08:54 UTC
Message-ID
<20200919085441.7621-2-luke@diamand.org>
In-Reply-To
<20200919085441.7621-1-luke@diamand.org>

git-p4 unshelve uses HEAD^$n to find the parent commit, which fails if there is an additional commit.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9832-unshelve.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/t9832-unshelve.sh b/t/t9832-unshelve.sh
index e9276c48f4..feda4499dd 100755
--- a/t/t9832-unshelve.sh
+++ b/t/t9832-unshelve.sh
@@ -29,8 +29,11 @@ test_expect_success 'init depot' '
 	)
 '
 
+# Create an initial clone, with a commit unrelated to the P4 change
+# on HEAD
 test_expect_success 'initial clone' '
-	git p4 clone --dest="$git" //depot/@all
+	git p4 clone --dest="$git" //depot/@all &&
+    test_commit -C "$git" "unrelated"
 '
 
 test_expect_success 'create shelved changelist' '
@@ -77,7 +80,7 @@ EOF
 	)
 '
 
-test_expect_success 'update shelved changelist and re-unshelve' '
+test_expect_failure 'update shelved changelist and re-unshelve' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$cli" &&
-- 
2.28.0
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 5 in “git-p4: unshelve uses HEAD^n, not HEAD~n”
  1. 0/2 git-p4: unshelve uses HEAD^n, not HEAD~nLuke Diamand, Sep 19, 2020
  2. 1/2 git-p4 unshelve: adding a commit breaks git-p4 unshelveLuke Diamand, Sep 19, 2020
  3. 2/2 git-p4: use HEAD~$n to find parent commit for unshelveLuke Diamand, Sep 19, 2020
  4. Eric SunshineSep 20, 2020
  5. Eric SunshineSep 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.